-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Azure Cognitive Search] Add default response to Operations API #11515
[Azure Cognitive Search] Add default response to Operations API #11515
Conversation
Hi, @brjohnstmsft Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Validation Report
|
Rule | Message |
---|---|
1011 - AddingResponseCode |
The new version adds a response code 'default'. New: Microsoft.Search/preview/2020-08-01-preview/search.json#L56:11 |
1011 - AddingResponseCode |
The new version adds a response code 'default'. New: Microsoft.Search/stable/2020-08-01/search.json#L56:11 |
️️✔️
~[Staging] LintDiff succeeded [Detail]
Validation passes for LintDiff.
️️✔️
~[Staging] Avocado succeeded [Detail]
Validation passes for Avocado.
️️✔️
~[Staging] ModelValidation succeeded [Detail]
Validation passes for ModelValidation.
️️✔️
~[Staging] SemanticValidation succeeded [Detail]
Validation passes for SemanticValidation.
️️✔️
~[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail]
There are no breaking changes.
️️✔️
~[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail]
There are no breaking changes.
Swagger Generation Artifacts
|
Azure Pipelines successfully started running 1 pipeline(s). |
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-java - Release
|
azure-sdk-for-js - Release
|
azure-sdk-for-go - Release
|
azure-sdk-for-net - Release
|
azure-sdk-for-python - Release
|
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Hi @brjohnstmsft, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
This is not a breaking change because no user-visible aspect of the API has changed; We're just documenting a behaviour that already existed. |
@brjohnstmsft Adding new response code is indeed breaking change according to @jianyexi. Please go through breaking change review. |
Azure Pipelines successfully started running 1 pipeline(s). |
@ChenTanyi The API itself did not change. The Swagger erroneously omitted the default response. So in reality, nothing is breaking. |
@ChenTanyi Please merge at your earliest convenience. |
…e#11515) Co-authored-by: Bruce Johnston <brjohnst@microsoft.com>
This change fixes a KPI warning for the Operations API of the Azure Cognitive Search RP.
FYI @tjacobhi
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.